Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

processor(ticdc): add min resolved/checkpoint table ID metrics (#4198) #4233

Merged
merged 5 commits into from
Jan 18, 2022
Merged

processor(ticdc): add min resolved/checkpoint table ID metrics (#4198) #4233

merged 5 commits into from
Jan 18, 2022

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jan 5, 2022 •
edited by overvenus
Loading

This is an automated cherry-pick of #4198 and #4375

What problem does this PR solve?

Replace a high cardinality metric with a low one.

Issue Number: ref #2183

What is changed and how it works?

Add min resolved/checkpoint table ID metrics.

Check List

  • Manual test (add detailed scripts or steps below)

image
Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update key monitor metrics in both TiCDC document and official document

Release note 

None

@overvenus @ti-chi-bot
This is an automated cherry-pick of pingcap#4198
b540b8a 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Jan 5, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 5, 2022
Merged
@ti-chi-bot ti-chi-bot added component/metrics-logging Metrics and logging component. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. labels Jan 5, 2022
@overvenus overvenus added this to the v5.2.4 milestone Jan 6, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.2@87115bc). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.2      #4233   +/-   ##
================================================
  Coverage               ?   57.2945%           
================================================
  Files                  ?        189           
  Lines                  ?      19124           
  Branches               ?          0           
================================================
  Hits                   ?      10957           
  Misses                 ?       7220           
  Partials               ?        947

@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 18, 2022
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 54eb336

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 18, 2022
@overvenus
Copy link
Member

/run-integration-test

@ti-chi-bot ti-chi-bot merged commit d460e74 into pingcap:release-5.2 Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@overvenus overvenus

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/metrics-logging Metrics and logging component. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR.
Projects
None yet
Milestone
v5.2.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @codecov-commenter @overvenus @VelocityLight